Skip to content

Fix docs: Add missing words in understanding page #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bqrkhn
Copy link
Contributor

@bqrkhn bqrkhn commented Apr 30, 2025

Was going through the docs and found minor issue. The sentence did not any make sense.

This PR fixes that.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bqrkhn bqrkhn changed the title Fix missing words in understanding page Fix docs: Add missing words in understanding page Apr 30, 2025
@bqrkhn
Copy link
Contributor Author

bqrkhn commented Apr 30, 2025

Should I change this:

The Open Source version uses SQLite, and soon Postgres or MySQL.

To this:

The Open Source version uses SQLite, Postgres and MySQL.

Since now convex self hosting supports that. This text is in the same database section.

@nipunn1313
Copy link
Collaborator

Should I change this:

The Open Source version uses SQLite, and soon Postgres or MySQL.

To this:

The Open Source version uses SQLite, Postgres and MySQL.

Since now convex self hosting supports that. This text is in the same database section.

Yeah! Go for it!

Copy link
Collaborator

@nipunn1313 nipunn1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. The previous wording is colloquial (works in some contexts/dialects) - but the new wording you propose sounds broadly better.

@nipunn1313
Copy link
Collaborator

I'll merge this as is - you can make another PR for the other fix! Appreciate it!

@nipunn1313
Copy link
Collaborator

@nipunn1313 nipunn1313 closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants