Skip to content

Enhance docs with DevContainer guide #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

iamfj
Copy link
Contributor

@iamfj iamfj commented May 2, 2025

  • Added an example DevContainer configuration for running Convex in a containerized environment.
  • Updated README.md to include a guide on integrating Convex with DevContainers for reproducible local development.
  • The DevContainer setup includes necessary mounts, port forwarding, and commands for easy onboarding and consistent development experience.

#79

@iamfj iamfj marked this pull request as ready for review May 2, 2025 18:42
Comment on lines 31 to 39
> [!TIP]
> **Local Development: Add Convex to Your Own DevContainer**
>
> Want to use Convex in your own project with a reproducible, containerized local development environment?
> Check out our [DevContainer guide](./devcontainer/README.md) for step-by-step instructions on how to add Convex to > your own repository using Visual Studio Code and Docker. This approach lets you spin up a fully configured Convex > backend for local development, with no manual dependency setup required.
>
> **To get started:**
> Follow the instructions in [self-hosted/devcontainer/README.md](./devcontainer/README.md) to add a DevContainer > configuration to your project and run Convex locally inside Docker.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I ask to remove this portion for now.
Just because Convex also has a local development setup built into npx convex dev and I don't want to confuse our customers around it. I'll think about it more, but for now, let's just add the new doc in the subdirectory.

I think there's probably a good way we can shout out devcontainers in the main README as another option, but I want to try and steer away from strongly recommending it near the top until it's more battle tested over time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to navigate carefully between things that are built by / supported by Convex vs things that are more community built and supported - so I'm thinking about how to do that as well.

Love the contributions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send a PR in the future with something for the main README and add you as a reviewer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I can remove it—no problem.

And if you ever decide to add a DevContainer setup for the convex-backend project itself, feel free to reach out. I’d be glad to contribute!

- Added an example DevContainer configuration for running
  Convex in a containerized environment.
- Updated `README.md` to include a guide on integrating
  Convex with DevContainers for reproducible local
  development.
- The DevContainer setup includes necessary mounts, port
  forwarding, and commands for easy onboarding and
  consistent development experience.

get-convex#79
@iamfj iamfj force-pushed the docs-add-guide-to-use-devcontainer-env branch from a81adfb to 77b21cd Compare May 3, 2025 17:16
@iamfj iamfj requested a review from nipunn1313 May 3, 2025 17:16
@nipunn1313
Copy link
Collaborator

0706e63

Sorry for delay! It's in!
I did prettier formatting + added a tiny "community maintained" at the top.

@nipunn1313 nipunn1313 closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants