Skip to content

Fix export for Safari #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix export for Safari #12

wants to merge 1 commit into from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 27, 2025 •
edited
Loading

It's so dumb, but it seems to work for me. Not sure we can accept this, but...

Of course, it does slow down things also for Firefox, Chrome...

@distantnative distantnative self-assigned this Jan 27, 2025
@distantnative distantnative linked an issue Jan 27, 2025 that may be closed by this pull request
Safari: Console errors on download & image incorrect #4
Open
@bastianallgeier
Copy link
Member

bastianallgeier commented Jan 28, 2025 •
edited
Loading

Ok, this is indeed a sledgehammer method 😆 That's almost stupid enough to think about detecting Safari in JS first and only apply it there.

EDIT: It turns out that you can really just do window.safari as a check 🤯 I think we should use that to wrap the stupidity in an if clause.

@lukasbestle
Copy link
Member

The conditional comments of the 20s 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier Awaiting requested review from bastianallgeier

Assignees

@distantnative distantnative

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safari: Console errors on download & image incorrect
3 participants
@distantnative @bastianallgeier @lukasbestle