Skip to content

ci: run tests on arm64 #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2025
Merged

ci: run tests on arm64 #3750

merged 7 commits into from
Jul 2, 2025

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Jun 14, 2025

Let's see if this works

Closes #1586

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505
Copy link
Collaborator Author

aldy505 commented Jun 19, 2025

Ah, symbolicator's still missing the nightly images published to DockerHub. Sigh..

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (acbdee4) to head (a51e475).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3750   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 marked this pull request as ready for review July 2, 2025 02:05
@aldy505 aldy505 mentioned this pull request Jul 2, 2025
@aldy505 aldy505 enabled auto-merge (squash) July 2, 2025 04:30
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#standard-github-hosted-runners-for-public-repositories

Linux [Public preview] 4 16 GB 14 GB arm64 ubuntu-24.04-arm, ubuntu-22.04-arm

Arm is still in public preview of GHA, so maybe we should take cautions about adding it, as failing arm actions will prevent us from merging x86_64 fixes as well.

Also is there a problem with ubuntu 22? Changing multiple things in one PR always alerts me :-)

@aldy505
Copy link
Collaborator Author

aldy505 commented Jul 2, 2025

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#standard-github-hosted-runners-for-public-repositories

Linux [Public preview] 4 16 GB 14 GB arm64 ubuntu-24.04-arm, ubuntu-22.04-arm

Arm is still in public preview of GHA, so maybe we should take cautions about adding it, as failing arm actions will prevent us from merging x86_64 fixes as well.

That was the thoughts of Sentry employees the first time I implemented this on all repositories (sentry, snuba, etc). We can remove it if it became troublesome, and it's not a required precondition in order to merge.

Also is there a problem with ubuntu 22? Changing multiple things in one PR always alerts me :-)

I don't remember that there are Ubuntu 22 ARM runners. So I went ahead for 24.04.

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI passes, I'm game!

@aldy505 aldy505 merged commit b5a0158 into master Jul 2, 2025
13 checks passed
@aldy505 aldy505 deleted the ci/runs-tests-on-arm64 branch July 2, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add macOS to CI
3 participants