-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ci: run tests on arm64 #3750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests on arm64 #3750
Conversation
Ah, symbolicator's still missing the nightly images published to DockerHub. Sigh.. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3750 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 3 3
Lines 183 183
=======================================
Hits 182 182
Misses 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux [Public preview] 4 16 GB 14 GB arm64 ubuntu-24.04-arm, ubuntu-22.04-arm
Arm is still in public preview of GHA, so maybe we should take cautions about adding it, as failing arm actions will prevent us from merging x86_64 fixes as well.
Also is there a problem with ubuntu 22? Changing multiple things in one PR always alerts me :-)
That was the thoughts of Sentry employees the first time I implemented this on all repositories (sentry, snuba, etc). We can remove it if it became troublesome, and it's not a required precondition in order to merge.
I don't remember that there are Ubuntu 22 ARM runners. So I went ahead for 24.04. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as CI passes, I'm game!
Let's see if this works
Closes #1586
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.