New User Feedback Widget #4450

stefanosiano · 2025-05-26T18:17:54Z

📜 Description

Added SentryUserFeedbackWidget, with styles and icon
MainActivity sendFeedback reverted to call API, with new widget to open dialog
Added widget ui tests

💡 Motivation and Context

Implements last part of #3613

💚 How did you test it?

UI tests

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Added Scopes.captureFeedback API Changed the MainActivity sample app to use the new API

captureFeedback does not update scope lastEventId anymore

added SentryOptions.beforeSendFeedback implemented SentryClient.captureFeedback

# Conflicts: # CHANGELOG.md # sentry/api/sentry.api # sentry/src/main/java/io/sentry/SentryClient.java

added first draft of SentryUserFeedbackDialog

…idget # Conflicts: # CHANGELOG.md

added feedbackOptions to SentryOptions added callbacks to SentryUserFeedbackDialog

added feedback message truncation SentryClient doesn't check for backfillable feedbacks anymore

…idget # Conflicts: # CHANGELOG.md

added dialog theme to sample app MainActivity "send user feedback" button now opens feedback dialog instead of sending feedback

# Conflicts: # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java # sentry/api/sentry.api # sentry/src/main/java/io/sentry/HubAdapter.java # sentry/src/main/java/io/sentry/HubScopesWrapper.java # sentry/src/main/java/io/sentry/IScopes.java # sentry/src/main/java/io/sentry/NoOpHub.java # sentry/src/main/java/io/sentry/NoOpScopes.java # sentry/src/main/java/io/sentry/Scopes.java # sentry/src/main/java/io/sentry/ScopesAdapter.java # sentry/src/main/java/io/sentry/SentryClient.java # sentry/src/main/java/io/sentry/transport/RateLimiter.java

…ings

fixed feedback form behaviour added manifest options

updated changelog

added delegate listener to avoid user overwriting our OnDismissListener for the feedback dialog

# Conflicts: # CHANGELOG.md

…backOptions

MainActivity sendFeedback reverted to call API, with new widget to open dialog Added widget ui tests

github-actions · 2025-05-26T18:18:26Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b504f79

github-actions · 2025-05-26T18:35:22Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	389.31 ms	422.42 ms	33.11 ms
Size	1.58 MiB	2.12 MiB	550.52 KiB

Previous results on branch: feat/user-feedback-button

Startup times

Revision	Plain	With Sentry	Diff
`2797e56`	381.71 ms	412.46 ms	30.74 ms
`028a1a6`	425.28 ms	436.12 ms	10.84 ms
`ccf0e60`	433.57 ms	468.52 ms	34.95 ms
`d715551`	409.58 ms	436.84 ms	27.26 ms
`3b384b2`	487.09 ms	575.53 ms	88.44 ms

App size

Revision	Plain	With Sentry	Diff
`2797e56`	1.58 MiB	2.12 MiB	550.08 KiB
`028a1a6`	1.58 MiB	2.12 MiB	549.40 KiB
`ccf0e60`	1.58 MiB	2.12 MiB	549.78 KiB
`d715551`	1.58 MiB	2.12 MiB	550.08 KiB
`3b384b2`	1.58 MiB	2.12 MiB	549.54 KiB

# Conflicts: # CHANGELOG.md

added SentryUserFeedbackDialog.Builder, allowing a configuration being passed for the current dialog options added SentryFeedbackOptions copy constructor

# Conflicts: # sentry-android-core/api/sentry-android-core.api # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java

# Conflicts: # CHANGELOG.md # sentry-android-core/api/sentry-android-core.api # sentry-android-core/src/main/res/layout/sentry_dialog_user_feedback.xml # sentry-android-integration-tests/sentry-uitest-android/src/androidTest/java/io/sentry/uitest/android/UserFeedbackUiTest.kt # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java

renamed asset files to sentry_...

markushi

Looks good to me, just left a few nits around naming 😅

sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackWidget.java

sentry-android-core/src/main/res/drawable/sentry_campaign_24.xml

romtsn

LGTM, not for this PR but I guess we should also provide something for Compose

renamed UF button logo

langsmith · 2025-07-03T22:41:06Z

LGTM, not for this PR but I guess we should also provide something for Compose

Yes, please provide Compose support for this. Thanks.

stefanosiano added 30 commits March 14, 2025 12:42

added Feedback class and extended Contexts with it

62e71ff

Added Sentry.captureFeedback API

c9b4850

Added Scopes.captureFeedback API Changed the MainActivity sample app to use the new API

updated changelog

813ff1d

added tests

dd2d6a8

added scope replay id and screen as url

6428dfa

captureFeedback does not update scope lastEventId anymore

added feedback as DataCategory for rate limit and client report

144bcca

added SentryOptions.beforeSendFeedback implemented SentryClient.captureFeedback

Merge branch 'refs/heads/main' into feat/new-user-feedback-logic

509f992

# Conflicts: # CHANGELOG.md # sentry/api/sentry.api # sentry/src/main/java/io/sentry/SentryClient.java

merged main

3c0a6fb

added tests

9e1066e

Merge branch 'refs/heads/main' into feat/new-user-feedback-logic

eadb567

fixed tests

8feeadc

started adding resources for UF widget

986772d

started SentryFeedbackOptions

e19d122

added first draft of SentryUserFeedbackDialog

Merge branch 'feat/new-user-feedback-logic' into feat/user-feedback-w…

79052ad

…idget # Conflicts: # CHANGELOG.md

added all form options

5a83bb8

added feedbackOptions to SentryOptions added callbacks to SentryUserFeedbackDialog

Merge branch 'main' into feat/new-user-feedback-logic

ee44b18

merged main

212ffbf

added feedback message truncation SentryClient doesn't check for backfillable feedbacks anymore

Merge branch 'feat/new-user-feedback-logic' into feat/user-feedback-w…

2bf99b5

…idget # Conflicts: # CHANGELOG.md

user feedback dialog now uses dialogTheme

6eb876c

added dialog theme to sample app MainActivity "send user feedback" button now opens feedback dialog instead of sending feedback

merged main

d47f374

removed java options for send button colors. Replaced with theme sett…

1a758a2

…ings

added tests and UI tests

9315f7b

fixed feedback form behaviour added manifest options

added comments

62cea5e

updated changelog

added comments

794bd66

updated changelog

added replay capturing on feedback dialog open

f16ac66

added delegate listener to avoid user overwriting our OnDismissListener for the feedback dialog

added cancel button ui test

5388b42

added cancel button ui test

8aacd36

Merge branch 'refs/heads/main' into feat/user-feedback-widget

8750c8d

# Conflicts: # CHANGELOG.md

added Feedback.toString() and default values in javadoc of SentryFeed…

6d14499

…backOptions

markushi and others added 2 commits May 22, 2025 11:23

Merge branch 'main' into feat/user-feedback-widget

202759f

added SentryUserFeedbackWidget, with styles and icon

6253aca

MainActivity sendFeedback reverted to call API, with new widget to open dialog Added widget ui tests

updated changelog

c6d1919

stefanosiano marked this pull request as ready for review May 27, 2025 15:14

stefanosiano requested review from adinauer, romtsn, markushi and lcian as code owners May 27, 2025 15:14

stefanosiano added 8 commits May 29, 2025 16:07

Merge branch 'main' into feat/user-feedback-widget

7bc01eb

# Conflicts: # CHANGELOG.md

Merge branch 'feat/user-feedback-widget' into feat/user-feedback-button

ce10336

# Conflicts: # CHANGELOG.md

Update CHANGELOG.md

933371d

removed rtl properties and supportsRtl flag

eebaaf3

added SentryUserFeedbackDialog.Builder, allowing a configuration being passed for the current dialog options added SentryFeedbackOptions copy constructor

updated changelog

3fef7c4

Merge branch 'main' into feat/user-feedback-widget

536d522

Merge branch 'feat/user-feedback-widget' into feat/user-feedback-button

6d9cee3

# Conflicts: # sentry-android-core/api/sentry-android-core.api # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java

merged main

1bb3095

Base automatically changed from feat/user-feedback-widget to main June 13, 2025 15:40

stefanosiano added 3 commits June 13, 2025 17:58

merged main

4e5ad3a

renamed asset files to sentry_...

fixed ui tests

5cdbaca

markushi approved these changes Jun 17, 2025

View reviewed changes

sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackWidget.java Outdated Show resolved Hide resolved

sentry-android-core/src/main/res/drawable/sentry_campaign_24.xml Outdated Show resolved Hide resolved

romtsn approved these changes Jun 17, 2025

View reviewed changes

stefanosiano added 2 commits June 17, 2025 13:17

Renamed SentryUserFeedbackWidget to SentryUserFeedbackButton

8a1ef90

renamed UF button logo

Merge branch 'main' into feat/user-feedback-button

b504f79

stefanosiano merged commit 58769f0 into main Jun 17, 2025
34 checks passed

stefanosiano deleted the feat/user-feedback-button branch June 17, 2025 11:32

jschmid mentioned this pull request Jun 24, 2025

Version 8.14.0 breaks resources merging #4516

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

New User Feedback Widget #4450

New User Feedback Widget #4450

Uh oh!

stefanosiano commented May 26, 2025

Uh oh!

github-actions bot commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 26, 2025 •

edited

Loading

Previous results on branch: feat/user-feedback-button

Startup times

App size

Uh oh!

markushi left a comment

Uh oh!

Uh oh!

Uh oh!

romtsn left a comment

Uh oh!

Uh oh!

langsmith commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

New User Feedback Widget #4450

New User Feedback Widget #4450

Uh oh!

Conversation

stefanosiano commented May 26, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Previous results on branch: feat/user-feedback-button

Startup times

App size

Uh oh!

markushi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romtsn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

langsmith commented Jul 3, 2025

Uh oh!

Uh oh!

github-actions bot commented May 26, 2025 •

edited

Loading

github-actions bot commented May 26, 2025 •

edited

Loading