Skip to content

feat(contexts): Add chipset to device context #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2025
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 23, 2025

📜 Description

  • Adds chipset (SoC manufacturer + model) to device contexts

Next steps would be:

  • Add it to relay so it knows about the property
  • Promote it to tags in snuba or make it searchable
  • Update product UI auto-suggestions and known keys

💡 Motivation and Context

It's useful sometimes (like in our replay case) to know when a crash is happening on specific chipsets.

Google Chrome 2025-06-23 20 41 29

💚 How did you test it?

Manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 23, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4be3a58

Copy link
Contributor

github-actions bot commented Jun 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.31 ms 420.71 ms 26.40 ms
Size 1.58 MiB 2.09 MiB 518.93 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@romtsn romtsn merged commit 34e71f7 into main Jun 24, 2025
34 checks passed
@romtsn romtsn deleted the rz/feat/device-chipset branch June 24, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants