Skip to content

Log parameter objects are now turned into String via toString #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 24, 2025

Conversation

adinauer
Copy link
Member

…sent## 📜 Description

Log parameter objects are now turned into String via toString

💡 Motivation and Context

We were sending the object as JSON instead of String due to the second constructor not converting the value.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.21 ms 446.88 ms 54.67 ms
Size 1.58 MiB 2.09 MiB 518.94 KiB

Previous results on branch: fix/logs-object-serialization-to-string

Startup times

Revision Plain With Sentry Diff
517f7d0 446.76 ms 472.65 ms 25.89 ms

App size

Revision Plain With Sentry Diff
517f7d0 1.58 MiB 2.09 MiB 518.81 KiB

Base automatically changed from feat/logback-logs to main June 24, 2025 12:56
@adinauer adinauer merged commit ea7b9c1 into main Jun 24, 2025
34 checks passed
@adinauer adinauer deleted the fix/logs-object-serialization-to-string branch June 24, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants