Skip to content

Add Ktor client integration #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add Ktor client integration #4527

wants to merge 20 commits into from

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 27, 2025

📜 Description

Add a Ktor client integration.
Functionality, options and tests are similar to our OkHttp integration.

💡 Motivation and Context

Part of #2684

💚 How did you test it?

End to end and manual tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

  • Changelog
  • Docs
  • Readme
  • Add module to main readme
  • Release
  • Add module to .craft.yml
  • Add module to release registry

Copy link
Contributor

github-actions bot commented Jun 27, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.83 ms 437.85 ms 39.02 ms
Size 1.58 MiB 2.09 MiB 518.92 KiB

Previous results on branch: lcian/feat/ktor-client

Startup times

Revision Plain With Sentry Diff
c3b3ac8 433.74 ms 490.08 ms 56.34 ms
df1fbd1 407.84 ms 424.93 ms 17.09 ms
1df63ce 429.52 ms 485.02 ms 55.50 ms
569c88a 406.86 ms 419.57 ms 12.72 ms
f316c06 427.39 ms 464.94 ms 37.55 ms
ec32652 354.67 ms 385.71 ms 31.04 ms
bc4c3ab 420.27 ms 462.92 ms 42.65 ms

App size

Revision Plain With Sentry Diff
c3b3ac8 1.58 MiB 2.09 MiB 518.90 KiB
df1fbd1 1.58 MiB 2.09 MiB 519.08 KiB
1df63ce 1.58 MiB 2.09 MiB 518.90 KiB
569c88a 1.58 MiB 2.09 MiB 519.08 KiB
f316c06 1.58 MiB 2.09 MiB 519.08 KiB
ec32652 1.58 MiB 2.09 MiB 518.89 KiB
bc4c3ab 1.58 MiB 2.09 MiB 518.90 KiB

@lcian lcian changed the title [WIP] Add Ktor client integration \Add Ktor client integration Jul 3, 2025
@lcian lcian changed the title \Add Ktor client integration Add Ktor client integration Jul 3, 2025
@lcian lcian marked this pull request as ready for review July 3, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants