fix(node): Use sentry forked @fastify/otel dependency with pinned Otel v1 deps
#16256
+9
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tel v1 deps The `@fastify/otel` instrumentation uses OpenTelemetry v2, but for the time being Sentry only supports OpenTelemetry v1. We forked the library at https://github.com/getsentry/fastify-otel/tree/otel-v1 and downgraded its dependencies to OpenTelemetry v1. Resolves: #16245
size-limit report 📦
|
mydea
reviewed
May 12, 2025
Co-authored-by: Francesco Gringl-Novy <[email protected]>
onurtemizkan
approved these changes
May 12, 2025
mydea
reviewed
May 12, 2025
| resolved "https://registry.yarnpkg.com/@fastify/otel/-/otel-0.6.0.tgz#f86dfa6711804d0087288d7fadc097b41feea5b1" | ||
| integrity sha512-lL+36KwGcFiAMcsPOLLsR+GV8ZpQuz5RLVstlgqmecTdQLTXVOe9Z8uwpMg9ktPcV++Ugp3dzzpBKNFWWWelYg== | ||
| "@fastify/otel@git+https://github.com/getsentry/fastify-otel.git#otel-v1": | ||
| version "0.8.0" |
There was a problem hiding this comment.
side note: this also bumps this from 0.6.0 to 0.8.0, which may be relevant too? maybe to note the changes in the PR description?
mydea
approved these changes
May 12, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@fastify/otelinstrumentation uses OpenTelemetry v2, but for the time being Sentry only supports OpenTelemetry v1. We forked the library at https://github.com/getsentry/fastify-otel/tree/otel-v1 and downgraded its dependencies to OpenTelemetry v1.For the downgrade work in the fork see: getsentry/fastify-otel@7893f70
Note: This also bumps the instrumentation from
0.6.0to0.8.0.Resolves: #16245