fix(core): Gracefully handle invalid baggage entries #16257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
reviewed
May 12, 2025
Comment on lines
+120
to
+123
| } catch { | ||
| // We ignore errors here, e.g. if the value cannot be URL decoded. | ||
| // This will then be skipped in the next step | ||
| return; |
There was a problem hiding this comment.
q: Do we maybe want to add a debug log in case of discarded entries?
There was a problem hiding this comment.
I was thinking about this, but this increases bundle size, not sure if worth it? 🤔
There was a problem hiding this comment.
ah, alright then probably not worth the tradeoff
size-limit report 📦
|
andreiborza
approved these changes
May 12, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16251