fix(react): Handle nested parameterized routes in reactrouterv3 transaction normalization #16274
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saction normalization
RulaKhaled
approved these changes
May 13, 2025
AbhiPrasad
requested changes
May 13, 2025
packages/react/src/reactrouterv3.ts
Outdated
|
|
||
| // Join all parts with '/', then replace multiple slashes with a single one. | ||
| let fullPath = pathParts.join('/'); | ||
| fullPath = fullPath.replace(/\/+/g, '/'); |
There was a problem hiding this comment.
We should check if reduce is faster than the join + replace here.
it will also likely be more bundle size efficient, and we can account for the edge case.
There was a problem hiding this comment.
thought about this more - I think this works. We can replace both const pathParts and the fullPath calculations.
return routesWithPaths.slice(index).reduce((acc, { path }) => {
const pathSegment = acc === '/' || acc === '' ? path : `/${path}`;
return `${acc}${pathSegment}`;
}, '');
There was a problem hiding this comment.
Reduce is 2.51% slower: https://jsbench.me/g2mamtp9bd/1
There was a problem hiding this comment.
On my M1 Macbook it does 102K ops/s, I don't think it matters that much. Added a commit here: c1144e2
sidx1024
changed the title
AbhiPrasad
approved these changes
May 13, 2025
mydea
pushed a commit
that referenced
this pull request
May 14, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #16274 Co-authored-by: AbhiPrasad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that routes like
/teams/:teamId/detailswere normalized to/teams:teamIddetailswhich is missing/and is incorrect.This PR updates the tests for the React Router v3 integration to ensure correct transaction name normalization for nested parameterized routes.
Specifically, it modifies the
normalizes transaction nametest case to include navigation to a route like/teams/:teamId/detailsand verifies that the resulting transaction name is correctly normalized. This addresses an issue where similar nested route patterns might not be handled correctly.