fix(browser): Ensure pageload & navigation spans have correct data #16279
+167
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things about our idle spans emitted from
browserTracingIntegration
:window.location.pathname
at the time when thepopstate
event is emitted - but at this point, this may not be updated yet. So anavigation
transaction would possibly have the pathname of the previous page as transaction name.HttpContext
integration at event processing time. However, at this time thewindow.location
data is also usually already of the following navigation, so the pageload would often have wrong request data associated to it. Now, we store this on the current scope at span creation time to ensure it is actually correct.WIP on top of #16277 for tests