ref(shared-views): Refactor feature flags and remove some more old components #91506
+30
−448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
commented
May 12, 2025
| @@ -25,10 +25,10 @@ function IssueListFilters({query, sort, onSortChange, onSearch}: Props) { | |||
| const organization = useOrganization(); | |||
|
|
|||
| const hasIssueViews = organization.features.includes('issue-stream-custom-views'); | |||
| const hasIssueViewSharing = useHasIssueViewSharing(); | |||
| const prefersStackedNav = usePrefersStackedNav(); | |||
There was a problem hiding this comment.
Here, and in severla other places, we used to check if the user had issue view sharing enabled. Since issue view sharing flag has been completely swallowed by the stacked nav flag, we can replace it with the usePrefersStackedNav() hook.
MichaelSun48
commented
May 12, 2025
| groupSearchView && | ||
| canEditIssueView({groupSearchView, user, organization}) | ||
| ) { | ||
| if (groupSearchView && canEditIssueView({groupSearchView, user, organization})) { |
There was a problem hiding this comment.
This component (PageTitle) is already gated by the stacked nav hook in a parent component (LeftNavViewsHeader)
MichaelSun48
commented
May 12, 2025
Comment on lines
-47
to
-49
| viewIds: newViews | ||
| .filter(view => view.id[0] !== '_' && !view.id.startsWith('default')) | ||
| .map(view => parseInt(view.id, 10)), |
There was a problem hiding this comment.
This shenanignas was cuz of the old default views and the "uncomitted" views. We can remove it now.
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
malwilley
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some components that are no longer being used as part of the issue view sharing release.
Also refactors some feature flag checks