Skip to content

fix(insights): makes web vital meter with issues button more responsive #94932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edwardgou-sentry
Copy link
Contributor

Updates Web Vital meter with issues button to be more responsive to fit smaller screen sizes
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 4, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review July 4, 2025 20:24
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner July 4, 2025 20:24
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Font Sizes in Meter Display

Font size inconsistency on screens under 1500px. The MeterValueText component uses fontSize.lg on smaller screens, but the nested NoValueContainer (which displays the '—' placeholder for no data) always retains headerFontSize. This causes the '—' placeholder to appear larger than actual meter values.

static/app/views/insights/browser/webVitals/components/webVitalMetersWithIssues.tsx#L322-L331

@media (max-width: 1500px) {
font-size: ${p => p.theme.fontSize.lg};
}
`;
const NoValueContainer = styled('span')`
color: ${p => p.theme.subText};
font-size: ${p => p.theme.headerFontSize};
`;

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@edwardgou-sentry edwardgou-sentry merged commit 0746e3b into master Jul 7, 2025
48 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/web-vital-meter-with-issue-responsive branch July 7, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants