-
Notifications
You must be signed in to change notification settings - Fork 11.8k
server
: inject date_string in llama 3.x template + fix date for firefunction v2
#12802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja
: inject date_string in llama 3.x + fix date for functionary v2
jinja
: inject date_string in llama 3.x + fix date for functionary v2jinja
: inject date_string in llama 3.x + fix date for firefunction v2
jinja
: inject date_string in llama 3.x + fix date for firefunction v2server
: inject date_string in llama 3.x template + fix date for firefunction v2
ggerganov
approved these changes
Apr 19, 2025
@ochafik Good to merge. |
CISC
reviewed
Apr 29, 2025
@ochafik Not sure what's going on, could be related to changes in master?
|
…to avoid truncation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12729
common_chat_params_init_llama_3_x
&common_chat_params_init_functionary_v3_1_llama_3_1
even when there's no toolsdate_string
for llama 3.xexamples/server/tests/unit/test_template.py
) to check the date appears in the prompt for llama 3.3 and firefunction v2cc/ @CISC