Skip to content

Use tagged version of llguidance that does not break the build #13413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

HRKings
Copy link
Contributor

@HRKings HRKings commented May 9, 2025

This is a very simple PR to bump the version of llguidance to the commit that implemented that added fancy-regex because the build with -DLLAMA_LLGUIDANCE=ON breaks without it.

This fixes #13412

@ggerganov ggerganov merged commit 7c28a74 into ggml-org:master May 9, 2025
1 check passed
@CISC
Copy link
Collaborator

CISC commented May 10, 2025

Oh, the irony? :)

/home/runner/work/llama.cpp/llama.cpp/common/llguidance.cpp: In function ‘LlgTokenizer* llama_sampler_llg_new_tokenizer(const llama_vocab*)’:
/home/runner/work/llama.cpp/llama.cpp/common/llguidance.cpp:192:5: error: missing initializer for member ‘LlgTokenizerInit::slices’ [-Werror=missing-field-initializers]
  192 |     };
      |     ^

@HRKings
Copy link
Contributor Author

HRKings commented May 10, 2025

Oh wow, haha. How did you get this error? @CISC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile bug: Build breaks with llguidance
3 participants