mtmd : move helpers to dedicated file #13442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref discussion: #13366 (comment) (cc @mattjcly)
These helper functions are suppose to be the equivalent of
common.cpp
, so by moving it to a dedicated file, we can prevent accidentally using internal mtmd API in the helper.2 exceptions of this rule are:
mtmd_helper_bitmap_init_from_file
mtmd_helper_bitmap_init_from_buf
The reason is because these APIs use internal struct from
clip.cpp
. Fromlibmtmd
perspective, we never want to exposeclip_context
to the outside world. However, the problem with these 2 APIs can be resolved by simply movestb_image
tomtmh_helper.cpp
. But since this is a breaking change toclip
, I'll do it later on.