clip : cap max image size 1024 for qwen vl model #13478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13445 #13467
An image of size 2592x1944 equivalents to over 20k tokens, which is an unreasonable amount of computation (equivalent to 41GB of VRAM)
And turns out, the problem is not isolated to llama.cpp, someone already discuss about this using HF implementation: https://huggingface.co/Qwen/Qwen2-VL-2B-Instruct/discussions/10
The solution is to cap image size to maximum 1024x1024, which brings down the max memory usage to 1830M
We maybe able to use less memory with flash attn, but given recent discussion about why it's not enabled by default on text model, I'm not sure what's the risk of adding flash attn to vision support. WDYT @ggerganov ?