Skip to content

scripts : fix compare-llama-bench.py show parameter #13514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

scripts : fix compare-llama-bench.py show parameter #13514

merged 1 commit into from
May 14, 2025

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented May 13, 2025 •
edited
Loading

When n_depth was added the slices that excluded n_prompt and n_gen from --show were not updated.

@CISC CISC requested a review from JohannesGaessler May 13, 2025 18:10
@github-actions github-actions bot added script Script related python python script changes labels May 13, 2025
JohannesGaessler
JohannesGaessler approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@CISC CISC merged commit be1d4a1 into master May 14, 2025
5 checks passed
@CISC CISC deleted the cisc/compare-llama-bench-show-fix branch May 14, 2025 06:41
Silver267 pushed a commit to Silver267/llama.cpp that referenced this pull request May 14, 2025
@CISC @Silver267
scripts : fix compare-llama-bench.py show parameter (ggml-org#13514)
b3cade6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesGaessler JohannesGaessler JohannesGaessler approved these changes

Assignees
No one assigned
Labels
python python script changes script Script related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CISC @JohannesGaessler