-
Notifications
You must be signed in to change notification settings - Fork 11.8k
ci : upgraded oneAPI version in SYCL workflows and dockerfile #13532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the release.yml to cp the depended dll files?
Update to oneAPI 2025.1.1, the depended dll list is changed.
So that the binary files can execute without install oneAPI separately.
Like
cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_sycl_blas.5.dll" ./build/bin
cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_core.2.dll" ./build/bin
cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_tbb_thread.2.dll" ./build/bin
There hasn't been changes to the lib versions in this update. |
Have you verified the release package of windows? |
As I said above. Versions did not change between library releases. So yes, it works. @ngxson I am not sure if we can merge this without your approval since you are the codeowner of the file. Is this ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great work!
Small changes to update the base image and oneAPI package version for a couple of windows jobs.
Already tested locally in both cases.