Skip to content

ci : upgraded oneAPI version in SYCL workflows and dockerfile #13532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alcpz
Copy link
Collaborator

@Alcpz Alcpz commented May 14, 2025

Small changes to update the base image and oneAPI package version for a couple of windows jobs.
Already tested locally in both cases.

@Alcpz Alcpz requested a review from ngxson as a code owner May 14, 2025 08:42
@github-actions github-actions bot added the devops improvements to build systems and github actions label May 14, 2025
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the release.yml to cp the depended dll files?
Update to oneAPI 2025.1.1, the depended dll list is changed.
So that the binary files can execute without install oneAPI separately.
Like

 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_sycl_blas.5.dll" ./build/bin
 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_core.2.dll" ./build/bin
 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_tbb_thread.2.dll" ./build/bin

@Alcpz
Copy link
Collaborator Author

Alcpz commented May 14, 2025

Could you update the release.yml to cp the depended dll files? Update to oneAPI 2025.1.1, the depended dll list is changed. So that the binary files can execute without install oneAPI separately. Like

 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_sycl_blas.5.dll" ./build/bin
 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_core.2.dll" ./build/bin
 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_tbb_thread.2.dll" ./build/bin

There hasn't been changes to the lib versions in this update.

@NeoZhangJianyu
Copy link
Collaborator

Could you update the release.yml to cp the depended dll files? Update to oneAPI 2025.1.1, the depended dll list is changed. So that the binary files can execute without install oneAPI separately. Like

 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_sycl_blas.5.dll" ./build/bin
 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_core.2.dll" ./build/bin
 cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_tbb_thread.2.dll" ./build/bin

There hasn't been changes to the lib versions in this update.

Have you verified the release package of windows?
Could the binary file execute without installing oneAPI package?

@Alcpz
Copy link
Collaborator Author

Alcpz commented May 15, 2025

As I said above. Versions did not change between library releases. So yes, it works.

@ngxson I am not sure if we can merge this without your approval since you are the codeowner of the file. Is this ok to merge?

Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants