server : passthrough the /models endpoint during loading #13535
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
approved these changes
May 14, 2025
tools/server/server.cpp
Outdated
| const auto handle_models = [¶ms, &ctx_server, &res_ok](const httplib::Request &, httplib::Response & res) { | ||
| const auto handle_models = [¶ms, &ctx_server, &state, &res_ok](const httplib::Request &, httplib::Response & res) { | ||
| server_state current_state = state.load(); | ||
| std::string model_meta; |
There was a problem hiding this comment.
Suggested change
| std::string model_meta; | |
| json model_meta = nullptr; |
Otherwise, the model_meta will always be a string, right?
ngxson
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain 3rd-party applications could use the information about the model currently being loaded. This change allows the
/modelsand/v1/modelsendpoints to passthrough.@ngxson Not sure if this is the correct way to do this, so suggestions are welcome.
cc @astoilkov