-
Notifications
You must be signed in to change notification settings - Fork 11.8k
sycl: disable reorder for sycl mulmat #13536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
sycl: disable reorder for sycl mulmat #13536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this is related to the discussions in #13003 (comment)
I don't know why I somehow couldn't reproduce these regressions at some point but I suspected this mul_mat could be the issue.
@sgeor255 |
@NeoZhangJianyu results for this model are included in the PR description. Here's the list of models I ran in the order they are listed in the PR description:
|
OK, got it! Thank you! |
I test this PR code on the private branch on Arc 770. Could you check it again? Following is the cmd and log.
|
I test on B570. Please focus on the wrong issue issue. |
@NeoZhangJianyu I wasn't able to reproduce the issue, the output looks good when I run llama-cli with the same prompt & oneapi 2025.1.1 Arc 770master
this branch
BM80master
this branch
|
The reorder optimisation introduced a prompt processing performance regression for Q4_0 models. This PR disables reorder for the sycl mulmat which is the culprit of this regression.
Some performance numbers on Arc A770
GGML_SYCL_DISABLE_OPT=1
build: 24e86ca (5377)
GGML_SYCL_DISABLE_OPT=0
build: 24e86ca (5377)
GGML_SYCL_DISABLE_OPT=0
build: 24e86ca (5377)