fix: proper error handling for missing elements in messages array (OpenAI compatible backend) #13540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enAI compatible backend)
CISC
approved these changes
May 14, 2025
|
FWIW I pulled down these changes, verified they fixed the issue I was having with the latest bartowski-Qwen2.5-7B-Instruct-1M-GGUF-Qwen2.5-7B-Instruct-1M-Q4_K_M.gguf model, and also verified that the logic adheres to the OpenAI platform docs specification. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #13521
Per discussion in that PR, implement proper logic for checking messages array elements, with meaningful error messages.