webui : improve accessibility for visually impaired people #13551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13531
NOTE: we don't aim to be WCAG compliant because we're currently lack of time & efforts to do that. However, what we can do is to make the UI usable with a screen reader
I used MacOS VoiceOver to test this, still not very happy about it because I don't know if it works well on all browsers.
At least on Firefox, I can select every button now (using tab) and their labels are being read correctly.
On safari, it just tells that there is a button without a label, which is quite annoying. Also, safari skip entirely the "upload file" button next to the "send message" button
Also, maybe because I don't know how to use a screen reader, but toast messages don't seem to be picked up (even though they use correct
aria-live
; the toast notification function is provided byreact-hot-toast
package) - A simple test case is to click on the "send" button without entering any message, it should read an error "Please enter a message"@domasofan can you check if this is now usable?