metal : reuse graphs #14570
Draft
metal : reuse graphs #14570
+205
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
ggerganov
added
the
demo
github-actions
bot
added
ggml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC for #14482 (comment)
This is a hacky implementation of the idea in the comment. It works but it does not lead to any measurable improvement. The reason is that we already do the CPU/GPU overlap by submitting the first 128 graph nodes and while their are computing, we prepare and submit the rest of the graph. This is already enough to completely mask the CPU overhead of constructing the Metal graph, so there is no point in adding logic to reuse a previous Metal graph.