Skip to content

ci: check types with mypy #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2021
Merged

ci: check types with mypy #1226

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
70aa1ab
test: sort MANIFEST.in and add missing test-requirements.txt
muggenhor Apr 23, 2021
4f9d492
test(tox): verify type annotations
muggenhor Apr 23, 2021
6d06f5a
test(mypy): don't give errors for every unannotated function
muggenhor Apr 23, 2021
74a1b17
test(mypy): don't complain about missing type hints for 'gitdb'
muggenhor Apr 23, 2021
6a23335
fix(mypy): properly describe link between parameter and return types
muggenhor Apr 23, 2021
c885781
improvement: teach mypy that Object.type is not always supposed to be…
muggenhor Apr 23, 2021
8470777
improvement: teach mypy how to deal with wildcard-imported objects
muggenhor Apr 23, 2021
76ba092
improvement(mypy): ignore false positives
muggenhor Apr 23, 2021
043e15f
ci: check types with mypy
muggenhor Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci: check types with mypy 
This will result in _partial_ type checking of the type annotations by
using mypy. Keep in mind though that mypy is performing _static_
analysis in a _dynamic_ language so it can only partially check for
correctness.

Some other tool(s) will be needed to have more complete type checking at
runtime. E.g. [typeguard].

[typeguard]: https://pypi.org/project/typeguard/
  • Loading branch information
@muggenhor
muggenhor committed Apr 23, 2021
commit 043e15fe140cfff8725d4f615f42fa1c55779402
5 changes: 5 additions & 0 deletions .github/workflows/pythonpackage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ jobs:
pip install flake8
# stop the build if there are Python syntax errors or undefined names
flake8 --ignore=W293,E265,E266,W503,W504,E731 --count --show-source --statistics
- name: Check types with mypy
run: |
set -x
pip install tox
tox -e type
- name: Test with nose
run: |
set -x
Expand Down