add author and committer in params of the commit function #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trigger travis-ci : close and reopen on mergeable request. |
|
Thank you. |
| @@ -247,7 +247,7 @@ def append_entry(cls, config_reader, filepath, oldbinsha, newbinsha, message): | |||
| raise ValueError("Shas need to be given in binary format") | |||
| #END handle sha type | |||
| assure_directory_exists(filepath, is_file=True) | |||
| entry = RefLogEntry((bin_to_hex(oldbinsha), bin_to_hex(newbinsha), Actor.committer(config_reader), (int(time.time()), time.altzone), message)) | |||
| entry = RefLogEntry((bin_to_hex(oldbinsha), bin_to_hex(newbinsha), config_reader, (int(time.time()), time.altzone), message)) | |||
There was a problem hiding this comment.
config_reader is now actually just the Actor instance of the committer. It would be very confusing to leave that name.
Also it breaks the API due to the type change. Code must be added to check the type of the input and act accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when doing a commit with GitPython, it is based solely on the parameters defined in the environment variables GIT_AUTHOR_NAME, GIT_AUTHOR_EMAIL, GIT_COMMITTER_NAME, GIT_COMMITTER_EMAIL.
It is very painful as a way of doing things.
This Pull Request allow to make a commit through the function commit the index class.
With this update, we can make a commit like that.
When author or committer params aren't specified, the default value is variable environment.
Results are off course in the logs entry.