Skip to content

remove forced verbose output for pull on a remote #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove forced verbose output for pull on a remote
  • Loading branch information
gal-leib authored Nov 2, 2022
commit a5e3e7ff1d66a867fd1e48d04fcfb73e56e38356
4 changes: 3 additions & 1 deletion git/remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,7 @@ def pull(
self,
refspec: Union[str, List[str], None] = None,
progress: Union[RemoteProgress, "UpdateProgress", None] = None,
verbose: bool = True,
kill_after_timeout: Union[None, float] = None,
**kwargs: Any,
) -> IterableList[FetchInfo]:
Expand All @@ -983,6 +984,7 @@ def pull(

:param refspec: see 'fetch' method
:param progress: see 'push' method
:param verbose: Boolean for verbose output
:param kill_after_timeout: see 'fetch' method
:param kwargs: Additional arguments to be passed to git-pull
:return: Please see 'fetch' method"""
Expand All @@ -991,7 +993,7 @@ def pull(
self._assert_refspec()
kwargs = add_progress(kwargs, self.repo.git, progress)
proc = self.repo.git.pull(
self, refspec, with_stdout=False, as_process=True, universal_newlines=True, v=True, **kwargs
self, refspec, with_stdout=False, as_process=True, universal_newlines=True, v=verbose, **kwargs
)
res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
if hasattr(self.repo.odb, "update_cache"):
Expand Down