Skip to content

Better document env_case test/fixture and cwd #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Better document env_case test/fixture and cwd #1657

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74d9c08
Better explain the env_case test
EliahKagan Sep 12, 2023
a59aaea
Condense an overly long comment
EliahKagan Sep 12, 2023
22b8dba
Improve git.util.cwd docstring
EliahKagan Sep 12, 2023
c547555
Clarify test relationship to env_case.py fixture
EliahKagan Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Condense an overly long comment 
To better focus on the key information.
  • Loading branch information
@EliahKagan
EliahKagan committed Sep 12, 2023
commit a59aaead478213b6fd83dd39c607baa2ead97e09
8 changes: 3 additions & 5 deletions test/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,9 @@ def test_it_avoids_upcasing_unrelated_environment_variable_names(self):
# process, so the name is not upcased even on Windows.
os.putenv(old_name, "1")

# Step 2: Create the child process that inherits the environment variable. It will see it
# in os.environ with an upcased name, but if it is not mutated through os.environ
# then it will pass it on to its own child processes with the original name. The
# child process will use GitPython, and we are testing that it passes the variable
# with the exact original name to its own child processes.
# Step 2: Create the child process that inherits the environment variable. The child uses
# GitPython, and we are testing that it passes the variable with the exact original
# name to its own child process (the grandchild).
cmdline = [
sys.executable,
fixture_path("env_case.py"),
Expand Down