-
-
Notifications
You must be signed in to change notification settings - Fork 944
Fix bugs affecting exception wrapping in rmtree callback #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2814263
Add a missing PermissionError xfail on Windows
EliahKagan fba59aa
Update "ACTUALLY skipped by" comments
EliahKagan 5039df3
Eliminate duplicate rmtree try-except logic
EliahKagan 683a3ee
Clean up git.objects.submodule.base imports
EliahKagan 2fe7f3c
Test current expected behavior of git.util.rmtree
EliahKagan d42cd72
Test situations git.util.rmtree shouldn't wrap
EliahKagan 2a32e25
Fix test bug that assumed staticmethod callability
EliahKagan b8e009e
In rmtree, have onerror catch only PermissionError
EliahKagan ccbb273
Fix onerror callback type hinting, improve style
EliahKagan 0b88012
Use onexc callback where supported
EliahKagan 7dd5904
Revise and update rmtree docstrings and comments
EliahKagan 196cfbe
Clean up test_util, reorganizing for readability
EliahKagan 100ab98
Add initial test_env_vars_for_windows_tests
EliahKagan 7604da1
Warn if HIDE_WINDOWS_*_ERRORS set in environment
EliahKagan eb51277
Make HIDE_* attributes always bool
EliahKagan 333896b
Treat false-seeming HIDE_* env var values as false
EliahKagan c11b366
Simplify HIDE_* env var test; add missing cases
EliahKagan f0e15e8
Further cleanup in test_util (on new tests)
EliahKagan a9b05ec
Clarify a test helper docstring
EliahKagan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Warn if HIDE_WINDOWS_*_ERRORS set in environment
This warns if the HIDE_WINDOWS_KNOWN_ERRORS or HIDE_WINDOWS_FREEZE_ERRORS environment variables are set. These behave unexpectedly, including (and especially) in their effect on the same-named git.util module attributes, and neither their effects nor those of those attributes are documented in a way that would have supported code outside the project relying on their specific semantics. The new warning message characterizes their status as deprecated. - This is now the case for HIDE_WINDOWS_KNOWN_ERRORS, and almost so for the same-named attribute, whose existence (though not its meaning) can technically be relied on due to inclusion in `__all__` (which this does *not* change). - But the HIDE_WINDOWS_FREEZE_ERRORS attribute was never guaranteed even to exist, so technically neither it nor the same-named environment variable are not *even* deprecated. The attribute's presence has never been reflected in the public interface of any GitPython component in any way. However, these attributes are still used by the tests. Furthermore, in the case of HIDE_WINDOWS_KNOWN_ERRORS, setting it is the only way to disable the behavior of converting errors from some file deletion operations into SkipTest exceptions on Windows. Since that behavior has not yet changed, but is unlikely to be desired outside of testing, no *attributes* are deprecated at this time, and no effort to warn from accessing or using attributes is attempted.
- Loading branch information
commit 7604da185ce12b9ef540aff3255580db02c88268
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.