-
-
Notifications
You must be signed in to change notification settings - Fork 944
Pr cmd raise with stderr on error #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Byron
merged 7 commits into
gitpython-developers:master
from
barry-scott:pr-cmd-raise-with-stderr-on-error
Jun 13, 2016
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5077fc7
Return all the stderr messge after an error is detected for pull()
barry-scott 78f3f38
Return stderr lines from a pull() call that fails
barry-scott 46201b3
Fix flake8 complaints
barry-scott 08a0fad
Make sure that stderr is converted to bytes
barry-scott 3565888
Merge remote-tracking branch 'upstream/master' into pr-cmd-raise-with…
barry-scott 4a5ceba
log all the output from stdout and stderr for debugging process failures
barry-scott 6891caf
Can get a str object from stream.read rather then bytes.
barry-scott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Return all the stderr messge after an error is detected for pull()
- Loading branch information
commit 5077fc7e4031e53f730676df4d8df5165b1d36cc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it' s enough to break after the first line indicating a problem ? My intuition is that the lines that follow on stderr contain context, that you probably want to catch as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works because of the 2nd break at line 591.
Also I see this work in testing.