Skip to content

Delete requirements.txt #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ignatenkobrain
Copy link

No description provided.

@Byron
Copy link
Member

Byron commented Dec 28, 2016

I am not sure what to think of this PR if you don't provide any motivation.
As all tests fail as well, so apparently more work is needed to get a merge.

@yarikoptic
Copy link
Contributor

yarikoptic commented Mar 1, 2017

FWIW, if that is to remove duplication from specifications here and within setup.py, then you could use the same trick as we and other projects do having smth (leaving with the comments etc):

# Theoretically we don't want -e here but ATM pip would puke if just .[full] is provided
# TODO -- figure it out and/or complain to pip folks
# -e .[full]

# this one should work but would copy entire . tree  so should be ran on a clean copy
.[full]

full here is one of our requires "flavors", so either remove or adjust accordingly ;)

@Byron
Copy link
Member

Byron commented Mar 2, 2017

I am closing this PR as there was no reply in 3 months. If @yarikoptic sees value though, please let me know and we figure something out.

@Byron Byron closed this Mar 2, 2017
@yarikoptic
Copy link
Contributor

that is ok with me -- no immediate need/desires ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants