Skip to content

git expects boolean value to be lower case #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

git expects boolean value to be lower case #578

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
307b10a
Fixes to support Python 2.6 again.
andy-maier Oct 21, 2016
d03e7db
Don't change the meaning of string literals
nvie Dec 7, 2016
7e0e682
fix(submodule): don't fail if tracking branch can't be setup
Byron Dec 8, 2016
8e8a45e
chore(lint): flake8
Byron Dec 8, 2016
e1c997e
chore(repo): remove comment
Byron Dec 8, 2016
d803684
fix(refs): handle quoted branch names
Byron Dec 8, 2016
f6963f4
chore(lint): flake8 pacification
Byron Dec 8, 2016
c0a805f
chore(version): 2.1.1
Byron Dec 8, 2016
2d4844d
fix(tag): improve tag resolution handling
Byron Dec 22, 2016
7cbd2c9
fix(remote): set_url() uses correct argument order
Byron Dec 22, 2016
aea8184
chore(lint): fix
Byron Dec 22, 2016
3f0318b
fix(remote): test
Byron Dec 22, 2016
eefe4be
DOC: minor typo
boidolr Dec 31, 2016
7052136
pip install using camellcase package name
vokimon Jan 15, 2017
0429bc3
git expects boolean value to be lower case
barry-scott Feb 2, 2017
47f3ce8
Merge remote-tracking branch 'upstream/master'
barry-scott Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
git expects boolean value to be lower case 
str(bool) returns capitialised True and False
that is not what git expects or compatible with
getboolean.
  • Loading branch information
@barry-scott
barry-scott committed Feb 2, 2017
commit 0429bc3ff88071d11b6095aa69f0fb205ae40452
8 changes: 7 additions & 1 deletion git/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,13 @@ def get_value(self, section, option, default=None):
return valuestr

def _value_to_string(self, value):
if isinstance(value, (int, float, bool)):
# git expects bool to be lower case true or false
if isinstance(value, bool):
if value:
return 'true'
else:
return 'false'
if isinstance(value, (int, float)):
return str(value)
return force_text(value)

Expand Down