Python3 compat #13
Closed
Python3 compat #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 6, 2014 16:08
Fix multiple issues about unused imports without breaking tests where assumptions are made on exporting imports to dependent modules. Remove unused variables and correct renaming whitespace issues.
Add in try/except to catch import errors with cStringIO and use StringIO from the io module instead. Also ensure that where write access is needed, create the StringIO without an initial string. Need to avoid passing an initial buffer value to cStringIO.StringIO() as it will return a read-only StringI object. Instead create the object first with no initial arguments to get a proper StringIO instance and then write the desired buffer to it.
|
Thank you. |
|
And actually I don't know which one is the better starting position, I will see if both efforts can be brought together. Thanks again for your efforts. |
|
I have tried it in python 3.4, and tests wouldn't run at all due to errors during import. It turns out that no print statement was converted to the function style yet, and there might be much more. Maybe you haven't pushed a few commits yet ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the tests to pass on python3, but I'm sure there is more work to be done to ensure that it fully works.