Skip to content

Remove duplicate const #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2015
Merged

Remove duplicate const #20

merged 1 commit into from
Apr 7, 2015

Conversation

Kronuz
Copy link
Contributor

@Kronuz Kronuz commented Apr 7, 2015

Remove duplicate const to stop the warning: "duplicate 'const' declaration specifier"

@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) to 81.86% when pulling de19ac6 on Kronuz:patch-1 into 9aae93e on gitpython-developers:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) to 81.86% when pulling de19ac6 on Kronuz:patch-1 into 9aae93e on gitpython-developers:master.

@Byron
Copy link
Member

Byron commented Apr 7, 2015

The const specifier is not intended to be a duplicate, but supposed to be an invariable pointer to an invariable uchar. As such, it will prevent accidental increments of dend, which indeed should never change.

Maybe it doesn't like the location of it, and wants const uchar* const ? Could you check if that fixes the issue as well, and modify the PR accordingly ?

Thank you

@Byron Byron added the feedback label Apr 7, 2015
@Kronuz
Duplicate const fixed
016b58f 
Remove duplicate `const` to stop the warning: "duplicate 'const' declaration specifier"
@Kronuz
Copy link
Contributor Author

Kronuz commented Apr 7, 2015

Understood.
Yes, that is exactly what you wanted then. Fixed the commit in the pull request, it now passes without warnings.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) to 81.86% when pulling 016b58f on Kronuz:patch-1 into 9aae93e on gitpython-developers:master.

@Byron Byron removed the feedback label Apr 7, 2015
@Byron
Copy link
Member

Byron commented Apr 7, 2015

Great, thank you !

Byron added a commit that referenced this pull request Apr 7, 2015
@Byron
Merge pull request #20 from Kronuz/patch-1
b4cde7d 
Remove duplicate `const`
@Byron Byron merged commit b4cde7d into gitpython-developers:master Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kronuz @coveralls @Byron