Skip to content

support open encoding utf-8 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Conversation

nooperpudd
Copy link

No description provided.

@Byron Byron merged commit 7f216d9 into gitpython-developers:master Sep 28, 2017
@Byron
Copy link
Member

Byron commented Sep 28, 2017

Thanks for your contribution. I assume this makes all refs work, not just those that are ascii compatible.

@brunson
Copy link

brunson commented Sep 28, 2017

Seems like it could use some unit tests.

@Byron
Copy link
Member

Byron commented Sep 29, 2017

Definitely, and they should be easy to manufacture too. I hope it will be contributed eventually.

In this case, specifying utf-8 directly should be backwards compatible, while allowing for utf-8 encoded bytes to be interpreted correctly. The default encoding is ascii in default python installations, which is naturally included in utf-8 encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants