Skip to content

web/flow: cleanup WebAuthn helper functions #14460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 10, 2025

Details

Remove utility functions we had as they are built in to the browser now

Requires #14461 to make sure nothing is broken, but local testing works fine


Seems like a lot of these APIs are only available on the latest Safari (18.4), which came out in late march...so we'll probably have to pull in this polyfill: https://github.com/MasterKale/webauthn-polyfills


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner May 10, 2025 00:48
Copy link

netlify bot commented May 10, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit f561400
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/684f5f47c9c81d0008af570b

Copy link

netlify bot commented May 10, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f561400
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/684f5f47c9c81d0008af5707
😎 Deploy Preview https://deploy-preview-14460--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@BeryJu BeryJu force-pushed the web/flow/cleanup-webauthn branch from 72efb90 to b116a03 Compare May 10, 2025 00:49
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (20e0748) to head (f561400).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14460   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         815      815           
  Lines       42122    42122           
=======================================
+ Hits        39073    39074    +1     
+ Misses       3049     3048    -1     
Flag Coverage Δ
e2e 47.59% <ø> (+<0.01%) ⬆️
integration 24.35% <ø> (+<0.01%) ⬆️
unit 90.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 10, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f561400e85a78d8cc906f24a2387085a12cef318
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f561400e85a78d8cc906f24a2387085a12cef318

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added 2 commits June 16, 2025 01:58
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu force-pushed the web/flow/cleanup-webauthn branch from b116a03 to c70f85a Compare June 15, 2025 23:58
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu merged commit e86c40a into main Jun 16, 2025
101 checks passed
@BeryJu BeryJu deleted the web/flow/cleanup-webauthn branch June 16, 2025 00:39
kensternberg-authentik added a commit that referenced this pull request Jun 16, 2025
* main: (43 commits)
  Web/cleanup/empty state better slot handling (#14289)
  website/docs: release notes for `2025.6.2` (#15065)
  website/docs: remove commented out config options (#15064)
  website/docs: postgres troubleshooting: get PGPASSWORD from POSTGRES_PASSWORD_FILE (#15039)
  core: bump goauthentik/fips-python from 3.13.4-slim-bookworm-fips to 3.13.5-slim-bookworm-fips (#15058)
  website: bump the eslint group in /website with 2 updates (#15059)
  web: bump the wdio group across 1 directory with 3 updates (#14593)
  web: bump @sentry/browser from 9.28.1 to 9.29.0 in /web in the sentry group across 1 directory (#15061)
  web: bump the eslint group across 2 directories with 2 updates (#15062)
  core: bump axllent/mailpit from v1.26.0 to v1.26.1 in /tests/e2e (#15060)
  core: bump pydantic from 2.11.5 to 2.11.7 (#15063)
  providers/oauth2: bug fixes from conformance testing (#15056)
  website/integrations: change nextcloud scope name to avoid confusion (#15050)
  web/flow: cleanup WebAuthn helper functions (#14460)
  web/elements: fix typo in localeComparator (#15054)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#15049)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in es (#15047)
  core, web: update translations (#15048)
  blueprints: add section support for organisation (#15045)
  core, web: update translations (#15043)
  ...
BeryJu added a commit that referenced this pull request Jun 20, 2025
This reverts commit e86c40a.

Signed-off-by: Jens Langhammer <[email protected]>

# Conflicts:
#	web/package-lock.json
BeryJu added a commit that referenced this pull request Jun 20, 2025
Revert "web/flow: cleanup WebAuthn helper functions (#14460)"

This reverts commit e86c40a.

Signed-off-by: Jens Langhammer <[email protected]>

# Conflicts:
#	web/package-lock.json
cavefire pushed a commit to cavefire/authentik that referenced this pull request Jun 24, 2025
* pass goauthentik#1

Signed-off-by: Jens Langhammer <[email protected]>

* pass goauthentik#2

Signed-off-by: Jens Langhammer <[email protected]>

* add polyfill

Signed-off-by: Jens Langhammer <[email protected]>

---------

Signed-off-by: Jens Langhammer <[email protected]>
cavefire pushed a commit to cavefire/authentik that referenced this pull request Jun 24, 2025
…" (goauthentik#15172)

Revert "web/flow: cleanup WebAuthn helper functions (goauthentik#14460)"

This reverts commit e86c40a.

Signed-off-by: Jens Langhammer <[email protected]>

# Conflicts:
#	web/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant