Embed game mode can break movie maker mode

[berarma]

Tested versions

• Reproducible in: 4.5dev5

System information

Debian GNU/Linux 12.10

Issue description

Running a project in embed mode at a different resolution than defined in the project, produces AVI files with incorrect resolution and aspect ratio. It also breaks #107188.

The problem is that in embed mode, the initialization of MovieWriter sometimes receives the project viewport size, and sometimes the embedded viewport size. But the frames sent have always the embedded viewport size.

Another related issue is that the embedded resolution may have odd dimension values, and #107188 requires even dimension values that are far more common when rendering. I'm not sure about the other video formats.

I think MovieWriter should record in the viewport size from the project settings and those problems would be solved. Or if that's not possible, add some measures to work around the issue or at least warn about it.

There was a similar error, same effect, different cause, that was reported in the forum and #71254.

Steps to reproduce

• Open any project.
• Make the viewport size in the Project Settings big enoough so that it has to be scaled down to fit the embedded window.
• Enable Movie Maker mode.
• Run the project.
• Check the resulting video.

This might take several tries because it doesn't always happen. In my case it happens like 4 out of 5 times. It looks like a race condition between the embedded process and the MovieWriter initialization.

Minimal reproduction project (MRP)

Any project. The viewport has to be big enough to not fit the embedded window.

[Fireye04]

Trying to repro on arch/i3; I'm just getting output that mirrors the runtime viewport size and nothing else.

The wording of the issue leaves me a bit confused though, would the preferred output be the dimensions set ahead of time in the "viewport size" settings, or the size of the viewport at runtime?

[berarma]

Thanks for testing.

Trying to repro on arch/i3; I'm just getting output that mirrors the runtime viewport size and nothing else.

I think it depends on code execution timing. I couldn't reproduce it always, but most of the times.

The wording of the issue leaves me a bit confused though, would the preferred output be the dimensions set ahead of time in the "viewport size" settings, or the size of the viewport at runtime?

The viewport size settings. I've edited my post to make it clearer.

[Fireye04]

Awesome; In that case I can successfully report full reproduction on both 4.5dev5 and 4.4.1 (arch/niri now).

In my testing I have observed that the recording will always match the runtime, and never the pre-set "viewport size" settings. If by chance the runtime viewport were to be set to the preset setting, then it will record at that preset setting, however if the window is altered, that change is mirrored in the video's output.