[3.x] Toggle Button hover-style are broken

[boruok]

Tested versions

• reproducible [6c3f393]
• not reproducible v3.6.stable.official [de2f0f1]

System information

Pop!_OS 22.04 LTS, GTX1060 6Gb 570.153.02

Issue description

Toggle-Button style are messed up in current upstream 3.x, it's look like default-style keep popping.

• hover
  
• normal
  
• pressed
  

# bad: [6c3f393623621b89802f5a1bb96bfd2086add27c] Merge pull request #107545 from lawnjelly/explicit_pool_vector
git bisect bad 6c3f393623621b89802f5a1bb96bfd2086add27c
# good: [de2f0f147c5b7eff2d0f6dbc35042a4173fd59be] Bump version to 3.6-stable \o/
git bisect good de2f0f147c5b7eff2d0f6dbc35042a4173fd59be
# bad: [585909ef69cb2bac0c278da8d5dfafa3fec8956d] Merge pull request #103763 from lawnjelly/global_get_fast
git bisect bad 585909ef69cb2bac0c278da8d5dfafa3fec8956d
# bad: [c50cae23f8e8b2ec3e5325b00bad149c4d260497] Merge pull request #98843 from kilian-diener/zip-path-utf8
git bisect bad c50cae23f8e8b2ec3e5325b00bad149c4d260497
# good: [287bc6f41e3d1c1c2064c75982d65a2e7111f651] Add warning when calling `is_action_just_pressed()` from `_input()`
git bisect good 287bc6f41e3d1c1c2064c75982d65a2e7111f651
# good: [3841d76515eb6f836937eccc891bf7956cb06001] Merge pull request #98234 from timothyqiu/locale-compare-cache
git bisect good 3841d76515eb6f836937eccc891bf7956cb06001
# good: [e8b4fe3c91709bb860317fb0a024627e820dfa1c] Merge pull request #98300 from timothyqiu/tree-coordinate-3.x
git bisect good e8b4fe3c91709bb860317fb0a024627e820dfa1c
# bad: [c31800bcdef2afe2855f984ccf1843ca7686f81f] Merge pull request #98511 from timothyqiu/button-hover-pressed
git bisect bad c31800bcdef2afe2855f984ccf1843ca7686f81f
# bad: [cc11089786de6fc84a58f4b0af004997131b5b02] Fix Button not listing `hover_pressed` stylebox
git bisect bad cc11089786de6fc84a58f4b0af004997131b5b02
# first bad commit: [cc11089786de6fc84a58f4b0af004997131b5b02] Fix Button not listing `hover_pressed` stylebox

Steps to reproduce

1. select current 3.x branch
2. update to latest upstream
3. compile template (additional flags added for speedup compilation)

scons target=release_debug tools=no optimize=size debug_symbols=no deprecated=no disable_3d=yes disable_advanced_gui=yes

4. make sure compiled
5. export build (or run web build)
6. click button
7. hover button

Minimal reproduction project (MRP)

New Game Project.zip

[lawnjelly]

@timothyqiu

Darn it, just cherry picked to 3.6 too the other day. Maybe a fix can be done before 3.6.1.

[timothyqiu]

The button's "Hover Pressed" stylebox is not overridden in the MRP, so it shows the default stylebox.

---

#98511 added a default Hover Pressed stylebox for Buttons in the default theme, so existing projects will need to override it manually after upgrading.

It has been quite a long time since I made the PR. Now I can't reproduce the bug I described in the PR (as shown in that GIF) even if I revert it locally. I guess we can revert that commit on both 3.6 and 3.x 😓

[lawnjelly]

That's okay is no sweat timothy, we haven't made any builds yet. 👍

[boruok]

by bad, i've tested case in 3.6 editor with 3.7 template. Turns out there a new property (Hover Pressed) introduced in 3.7
Now compiled a new editor, works as expected.