UndoRedo cannot bind to GlobalScope methods

[dawdle-deer]

Tested versions

• Reproducible in v4.4.stable.official [4c311cb]

System information

Godot v4.4.stable - Windows 10 (build 19044) - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1070 (NVIDIA; 32.0.15.7247) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)

Issue description

I was testing some UndoRedo behaviour, and realized it was not calling the result of print.bind correctly. Digging into it, I found the same issue with push_warning, seed, and randomize. It seems to be a universal problem with GlobalScope methods (though testing this is tricky, as most of these methods do not mutate state).

Steps to reproduce

Reproduction steps:

• Open and run test_scene.tscn in the repro project, or run the following GDScript

var undo_redo := UndoRedo.new()

func print_wrapper(s):
	print(s)

func print_rand():
	prints(randf(), randi())

func randomize_wrapper():
	randomize()

func seed_wrapper(s):
	seed(s)

func _ready() -> void:
  var neutralseed = 123456
  seed(neutralseed)
  print_rand()
  randomize()
  seed(neutralseed)
  print_rand()
  undo_redo.create_action("randomize")
  undo_redo.add_do_method(print_wrapper.bind("	no wrappers"))
  undo_redo.add_do_method(randomize)
  undo_redo.add_do_method(seed.bind(neutralseed))
  undo_redo.add_do_method(print_rand)
  undo_redo.add_do_method(print_wrapper.bind("	both wrappers"))
  undo_redo.add_do_method(randomize_wrapper)
  undo_redo.add_do_method(seed_wrapper.bind(neutralseed))
  undo_redo.add_do_method(print_rand)
  undo_redo.add_do_method(print_wrapper.bind("	test only seed"))
  undo_redo.add_do_method(randomize_wrapper)
  undo_redo.add_do_method(seed.bind(neutralseed))
  undo_redo.add_do_method(print_rand)
  undo_redo.add_do_method(print_wrapper.bind("	test only randomize"))
  undo_redo.add_do_method(seed_wrapper.bind(neutralseed))
  undo_redo.add_do_method(randomize)
  undo_redo.add_do_method(print_rand)
  undo_redo.add_do_method(print.bind("finished!"))
  undo_redo.commit_action()

Expected output:

0.61765211820602 3193628639
0.61765211820602 3193628639
	no wrappers
0.61765211820602 3193628639
	both wrappers
0.61765211820602 3193628639
	test only seed
0.61765211820602 3193628639
	test only randomize
[a random float] [a random int]
finished!

Actual output:

0.61765211820602 3193628639
0.61765211820602 3193628639
	no wrappers
0.34198194742203 2576548083
	both wrappers
0.61765211820602 3193628639
	test only seed
0.00454090256244 1907607115
	test only randomize
0.61765211820602 3193628639

Minimal reproduction project (MRP)

undoredo-repro-project.zip

[dalexeev]

A simplified example:

func _run() -> void:
    var neutralseed := 123456

    print("---")
    seed(neutralseed)
    print(randi())

    randomize()
    seed.bind(neutralseed).call()
    print(randi())

    randomize()
    var undo_redo := UndoRedo.new()
    undo_redo.create_action("Test")
    undo_redo.add_do_method(seed.bind(neutralseed))
    undo_redo.add_do_method(func (): print(randi()))
    undo_redo.commit_action()

---
2652795774
2652795774
1659112701
---
2652795774
2652795774
2840517533
---
2652795774
2652795774
4142111689

Looks like an UndoRedo bug? CC @KoBeWi

EDIT: It seems that the reason is that GDScriptUtilityCallable does not have a base object. I am not sure if the expectation of UndoRedo that there should always be an object is correct. But if it is absolutely necessary, we could use some singleton as a stub.

godot/core/object/undo_redo.cpp

Lines 346 to 358 in 5abed52

	void UndoRedo::_process_operation_list(List<Operation>::Element *E, bool p_execute) {
	const int PREALLOCATE_ARGS_COUNT = 16;
	LocalVector<const Variant *> args;
	args.reserve(PREALLOCATE_ARGS_COUNT);
	for (; E; E = E->next()) {
	Operation &op = E->get();
	Object *obj = ObjectDB::get_instance(op.object);
	if (!obj) { //may have been deleted and this is fine
	continue;
	}

godot/modules/gdscript/gdscript_utility_callable.cpp

Lines 77 to 79 in 5abed52

	ObjectID GDScriptUtilityCallable::get_object() const {
	return ObjectID();
	}