Editor inspector section displays hover feedback even if non-actionable due to not containing any visible properties (unchecked checkbox)

[Calinou]

Tested versions

• Reproducible in: 4.5.beta1
• Not reproducible in: 4.4.1.stable (checkbox-on-section feature is not present there)

System information

Godot v4.5.beta (efb40c1) - Fedora Linux 42 (KDE Plasma Desktop Edition) on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 5090 (nvidia; 575.64) - AMD Ryzen 9 9950X3D 16-Core Processor (32 threads) - 62.33 GiB memory

Issue description

When hovering a section in the inspector, the section background and text will brighten, which is good. However, this also happens when hovering a section that has an unchecked checkbox on it. These sections can't be unfolded by design, as they do not contain any visible properties until you tick the checkbox.

inspector_section_hover.mp4

We should do one of these two things:

1. Remove hover feedback on the section if it has an unchecked checkbox, but keep it for checked checkboxes as you can still (un)fold the section.
2. Make clicking the section tick the checkbox if it's currently unchecked.

I'm neutral on which one is the best solution here. Solution 2 is more seamless to the user, but is prone to accidentally activating some features, which can have a performance impact in some cases (e.g. shadows in Light3D).

cc @cier and @lodetrick, as they implemented the feature in #81630 and #105272.

Steps to reproduce

• Add an OmniLight3D node.
• Hover the mouse over the Shadow section in the inspector, then try to click it. See that nothing happens unless you tick the On checkbox next to it, but the section has visible hover feedback regardless.

Minimal reproduction project (MRP)

N/A

[lodetrick]

Thanks for the cc. If this is in master then its a regression, likely from #107591 or #107919. I can look into it and make a PR tonight.

In the original PR, KoBeWi suggested solution 1 when it was brought up.

Edit: Confirmed, it appeared in the initial PR

[timothyqiu]

I noticed a similar problem when testing the PR. Messages like "(2 changes)" are no longer drawn on the section header after I uncheck Enabled. But the message is shown if the group is not enabled when I start inspecting the node.

The "(2 changes)" text also makes me wonder whether hiding properties when unchecked is good experience. It requires enabling the group in order to check which properties are changed.

So I checked Blender. Checking/unchecking the header only affects whether the properties in the group are read-only. It does not interfere with whether the section is folded. Seems simpler.

[lodetrick]

The "(2 changes)" text not being shown was a bug, but you bring up an interesting point. I can create a draft PR to change the behavior to read only, just to get tangible feedback. Would that be a good course of action?