SceneTree rename popup reappears when triggering rename shortcut in different dock tab

[alessandrofama]

Tested versions

v4.3.dev.custom_build [9e65c5c]

System information

Godot v4.3.dev (9e65c5c) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 6900 XT (Advanced Micro Devices, Inc.; 31.0.22017.5002) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)

Issue description

The rename popup in the scene tree reappears when the rename shortcut is triggered inside another dock tab:

scene-tree-rename.mp4

Not sure how it was intended to work here: not showing the popup at all, or switching to the scene tree and showing the popup?

Steps to reproduce

1. Select a node in the scene tree and press the rename shortcut (F2).
2. Switch to another tab (i.e. Import).
3. Press the rename shortcut again: the popup will reappear.

Minimal reproduction project (MRP)

N/A

[rsubtil]

These are all the shortcuts that remain valid on this scenario:

godot/editor/scene_tree_dock.cpp

Lines 98 to 163 in 04eafd5

	void SceneTreeDock::shortcut_input(const Ref<InputEvent> &p_event) {
	ERR_FAIL_COND(p_event.is_null());
	if (get_viewport()->gui_get_focus_owner() && get_viewport()->gui_get_focus_owner()->is_text_field()) {
	return;
	}
	if (!p_event->is_pressed() || p_event->is_echo()) {
	return;
	}
	if (ED_IS_SHORTCUT("scene_tree/rename", p_event)) {
	_tool_selected(TOOL_RENAME);
	#ifdef MODULE_REGEX_ENABLED
	} else if (ED_IS_SHORTCUT("scene_tree/batch_rename", p_event)) {
	_tool_selected(TOOL_BATCH_RENAME);
	#endif // MODULE_REGEX_ENABLED
	} else if (ED_IS_SHORTCUT("scene_tree/add_child_node", p_event)) {
	_tool_selected(TOOL_NEW);
	} else if (ED_IS_SHORTCUT("scene_tree/instantiate_scene", p_event)) {
	_tool_selected(TOOL_INSTANTIATE);
	} else if (ED_IS_SHORTCUT("scene_tree/expand_collapse_all", p_event)) {
	_tool_selected(TOOL_EXPAND_COLLAPSE);
	} else if (ED_IS_SHORTCUT("scene_tree/cut_node", p_event)) {
	_tool_selected(TOOL_CUT);
	} else if (ED_IS_SHORTCUT("scene_tree/copy_node", p_event)) {
	_tool_selected(TOOL_COPY);
	} else if (ED_IS_SHORTCUT("scene_tree/paste_node", p_event)) {
	_tool_selected(TOOL_PASTE);
	} else if (ED_IS_SHORTCUT("scene_tree/paste_node_as_sibling", p_event)) {
	_tool_selected(TOOL_PASTE_AS_SIBLING);
	} else if (ED_IS_SHORTCUT("scene_tree/change_node_type", p_event)) {
	_tool_selected(TOOL_REPLACE);
	} else if (ED_IS_SHORTCUT("scene_tree/duplicate", p_event)) {
	_tool_selected(TOOL_DUPLICATE);
	} else if (ED_IS_SHORTCUT("scene_tree/attach_script", p_event)) {
	_tool_selected(TOOL_ATTACH_SCRIPT);
	} else if (ED_IS_SHORTCUT("scene_tree/detach_script", p_event)) {
	_tool_selected(TOOL_DETACH_SCRIPT);
	} else if (ED_IS_SHORTCUT("scene_tree/move_up", p_event)) {
	_tool_selected(TOOL_MOVE_UP);
	} else if (ED_IS_SHORTCUT("scene_tree/move_down", p_event)) {
	_tool_selected(TOOL_MOVE_DOWN);
	} else if (ED_IS_SHORTCUT("scene_tree/reparent", p_event)) {
	_tool_selected(TOOL_REPARENT);
	} else if (ED_IS_SHORTCUT("scene_tree/reparent_to_new_node", p_event)) {
	_tool_selected(TOOL_REPARENT_TO_NEW_NODE);
	} else if (ED_IS_SHORTCUT("scene_tree/save_branch_as_scene", p_event)) {
	_tool_selected(TOOL_NEW_SCENE_FROM);
	} else if (ED_IS_SHORTCUT("scene_tree/delete_no_confirm", p_event)) {
	_tool_selected(TOOL_ERASE, true);
	} else if (ED_IS_SHORTCUT("scene_tree/copy_node_path", p_event)) {
	_tool_selected(TOOL_COPY_NODE_PATH);
	} else if (ED_IS_SHORTCUT("scene_tree/show_in_file_system", p_event)) {
	_tool_selected(TOOL_SHOW_IN_FILE_SYSTEM);
	} else if (ED_IS_SHORTCUT("scene_tree/toggle_unique_name", p_event)) {
	_tool_selected(TOOL_TOGGLE_SCENE_UNIQUE_NAME);
	} else if (ED_IS_SHORTCUT("scene_tree/delete", p_event)) {
	_tool_selected(TOOL_ERASE);
	} else {
	return;
	}
	// Tool selection was successful, accept the event to stop propagation.
	accept_event();
	}

I think the best solution in order to avoid further confusing scenarios would be to prevent any shortcut key from working if the Scene tab is not currently visible. However, I don't know if a few of these actions are actually useful to remain available even when hidden, such as Add Node (Ctrl + A) and Duplicate (Ctrl + D).