Skip to content

Feature: add eager playback global option #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Feature: add eager playback global option #1591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
03e701b
Add eagerPlayback global option to use `canplay` event
jbgomez Apr 17, 2022
d65b610
Only update currentTime when next value differs
jbgomez Apr 17, 2022
a73d154
Add test cases for eagerPlayback
jbgomez Apr 17, 2022
69198d3
Update README
jbgomez Apr 17, 2022
937abfd
Change `_setEagerPlayback` to `_enableEagerPlayback`
jbgomez Apr 17, 2022
0e6723f
Add all global options to tests, refactor to ES5
jbgomez Apr 17, 2022
508644a
Consolidate global options parsing in parseGlobalOptions.js
jbgomez Apr 17, 2022
bd4d5c1
Add code comment explaining need for conditional
jbgomez Apr 17, 2022
3e5c2c6
Fix punctuation in code comment
jbgomez Apr 17, 2022
8c0c639
Remove ctx and masterGain global options from test page, update README
jbgomez Apr 17, 2022
ad40ffc
Update global options width on test page
jbgomez Apr 17, 2022
02d7087
Make usingWebAudio true by default on test page
jbgomez Apr 18, 2022
0448f11
Reconfigure global options layout on test page
jbgomez Apr 18, 2022
013946a
Update comment
jbgomez Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove ctx and masterGain global options from test page, update README
  • Loading branch information
@jbgomez
jbgomez committed Apr 17, 2022
commit 8c0c639c00798d6f9e64120ccfb271b6418c55a6
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,9 @@ Each HTML5 Audio object must be unlocked individually, so we keep a global pool
Automatically suspends the Web Audio AudioContext after 30 seconds of inactivity to decrease processing and energy usage. Automatically resumes upon new playback. Set this property to `false` to disable this behavior.
#### eagerPlayback `Boolean` `false`
When enabled, allows playback to begin before the browser has estimated that enough data has loaded in order to play the sound to its end, without having to stop and buffer for more content.
#### ctx `Boolean` *`Web Audio Only`*
#### ctx `AudioContext` `null` *`Web Audio Only`*
Exposes the `AudioContext` with Web Audio API.
#### masterGain `Boolean` *`Web Audio Only`*
#### masterGain `GainNode` `null` *`Web Audio Only`*
Exposes the master `GainNode` with Web Audio API. This can be useful for writing plugins or advanced usage.


Expand Down
8 changes: 0 additions & 8 deletions tests/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@ <h6 id="globalOptionsHeader">Global Options:</h6>
<input type="checkbox" id="eagerPlayback" name="eagerPlayback">
<label for="eagerPlayback">eagerPlayback</label>
</div>
<div class="option">
<input type="checkbox" id="ctx" name="ctx">
<label for="ctx">ctx</label>
</div>
<div class="option">
<input type="checkbox" id="masterGain" name="masterGain">
<label for="masterGain">masterGain</label>
</div>
</form>
<button class="button" id="webaudio">RUN WEB AUDIO TESTS</button>
<button class="button" id="html5">RUN HTML5 TESTS</button>
Expand Down