Skip to content

Prevent the code to fail when loading models without the "materials" property or having a mesh primitive without the material association #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Prevent the code to fail when loading models without the "materials" property or having a mesh primitive without the material association #3287

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34f9363
Adding the proper null check to let models with no materials load wit…
alexdaube Mar 17, 2022
5fd716c
Merge branch 'master' into model-with-no-materials-fix
alexdaube Mar 17, 2022
e5322b0
Merge branch 'master' into model-with-no-materials-fix
alexdaube Mar 18, 2022
ef78a62
Fix test file typo and removed unused test files format
alexdaube Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into model-with-no-materials-fix
  • Loading branch information
@alexdaube
alexdaube committed Mar 17, 2022
commit 5fd716cc3f39087699bae81c50996d6c855551f5

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.