Skip to content

Create Plugin: Support Node 24 #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

Create Plugin: Support Node 24 #1772

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8221faf
ci(gh-workflows): introduce matrix to test plugin scaffolds against s…
jackw May 7, 2025
808802b
feat(create-plugin): update webpack import paths to support node 24
jackw May 7, 2025
6a210a4
fix(create-plugin): fix webpack import error with node 24
jackw May 7, 2025
1431abe
fix(create-plugin): load json with fs for node compatibility
jackw May 8, 2025
73bf137
feat(create-plugin): more support node 24 in webpack config
jackw May 8, 2025
6f9dc4d
ci(gh-workflows): branch out and test all the node versions
jackw May 8, 2025
888ff66
ci(gh-workflows): remove node 21 and 23 from the node-versions test m…
jackw May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(create-plugin): load json with fs for node compatibility
  • Loading branch information
@jackw
jackw committed May 14, 2025
commit 1431abefa4cfcd33f978990ea47644fec6fd1788
13 changes: 9 additions & 4 deletions packages/create-plugin/templates/common/.config/webpack/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,22 @@ export function isWSL() {
}
}

function loadJson(path: string) {
const rawJson = fs.readFileSync(path, 'utf8');
return JSON.parse(rawJson);
}

export function getPackageJson() {
return require(path.resolve(process.cwd(), 'package.json'));
return loadJson(path.resolve(process.cwd(), 'package.json'));
}

export function getPluginJson() {
return require(path.resolve(process.cwd(), `${SOURCE_DIR}/plugin.json`));
return loadJson(path.resolve(process.cwd(), `${SOURCE_DIR}/plugin.json`));
}

export function getCPConfigVersion() {
const cprcJson = path.resolve(__dirname, '../', '.cprc.json');
return fs.existsSync(cprcJson) ? require(cprcJson).version : { version: 'unknown' };
const cprcJson = path.resolve(process.cwd(), './.config', '.cprc.json');
return fs.existsSync(cprcJson) ? loadJson(cprcJson).version : { version: 'unknown' };
}

export function hasReadme() {
Expand Down