Skip to content

Fix Frontend Observability App import #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Conversation

kpelelis
Copy link
Contributor

@kpelelis kpelelis commented May 5, 2025

This pull request addresses 2 issues with the frontend observability provider.

  1. Make sure importing Apps work by implementing the ImportState method
  2. Fix an inconsistency issue when updating apps where the collector url would not be set properly

Closes: #2115

kpelelis added 2 commits May 5, 2025 17:01
This commit adds support to import existing apps into Terraform

Closes: #2115
This commit fixes an issue where the collector endpoint would not be
populated correctly when updating an App. This was happening because
Frontend Observbility API will not return the collector URL on app
update.
@kpelelis kpelelis self-assigned this May 5, 2025
@kpelelis kpelelis requested review from a team as code owners May 5, 2025 14:04
Copy link

github-actions bot commented May 5, 2025

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@kpelelis kpelelis merged commit 3bae8a2 into main May 8, 2025
30 of 31 checks passed
@kpelelis kpelelis deleted the feat-fe-o11y-app-import branch May 8, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Import grafana_frontend_o11y_app Resources
2 participants