Recreate deleted k6 resources #2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
fornfrey
force-pushed
the
k6-resource-read-fix
branch
from
2338b21 to
371f96c
Compare
joanlopez
approved these changes
May 15, 2025
There was a problem hiding this comment.
Looks good, thanks @fornfrey!
I think it could be a very nice idea to try to write a test that:
- Loads a config directory, with a given resource (and so it creates it)
- Use the Go client/direct HTTP request to remove it.
- Try to reload the configuration, and see how it behaves (no error).
However, I'm not sure how easy that would be, and if there's any similar test for any other resource within the provider. If so, and it's easy to copy and adjust, I'd try it, if not, feel free to merge it as-is! We could look at it later.
Thanks! 🙌🏻
fornfrey
requested review from
facundobatista and
federicotdn
and removed request for
a team
joanlopez
reviewed
May 20, 2025
| script, httpResp, err := scriptReq.Execute() | ||
|
|
||
| if httpResp != nil && httpResp.StatusCode == http.StatusNotFound { | ||
| // 404 response from the script endpoin for an existing test means that the script is undefined |
There was a problem hiding this comment.
Suggested change
| // 404 response from the script endpoin for an existing test means that the script is undefined | |
| // 404 response from the script endpoint for an existing test means that the script is undefined |
joanlopez
approved these changes
May 20, 2025
spinillos
approved these changes
May 23, 2025
vortegatorres
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.