whisper-fetch: fix timestr when using --drop #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This more or less duplicates PR #306. I did the work before I looked through the issues and PR's. I don't much care which one is merged, though I think this is a slightly smaller and more concise change (but am obviously biased). Apart from the whitespace changes to adjust the indent in the non-json loop, the diffstat is |
Filtering the values list when --drop is set happens too early for the non-json output. When looping over the values we expect to be able to set the time string based on the number of times through the loop, adding the step value on each pass. With empty values stripped, the time gets further off for each value that is dropped. Move the drop filtering function to the appropriate places for both json and plain test output. Testing on databases with more than a year of data and many empty values, the time to execute is no different, so we should not be regressing in any significant way. Though even if we were, it is better to be accurate than fast if one or the other must be picked. Fixes graphite-project#250, fixes graphite-project#305.
tmzullinger
force-pushed
the
fetch-fix-drop-times
branch
from
9538637 to
f215ce3
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This is still relevant. If the change in #306 is used then this can be closed. But one or the other would be nice to have merged. |
|
Sure, missed that smh. Merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering the values list when --drop is set happens too early for the non-json output. When looping over the values we expect to be able to set the time string based on the number of times through the loop, adding the step value on each pass. With empty values stripped, the time gets further off for each value that is dropped.
Move the drop filtering function to the appropriate places for both json and plain test output.
Testing on databases with more than a year of data and many empty values, the time to execute is no different, so we should not be regressing in any significant way. Though even if we were, it is better to be accurate than fast if one or the other must be picked.
Fixes #250, fixes #305.