[v16] Move auth preference module validation to RPC layer #54763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/backport-54687/v16
branch
from
56d2e09 to
30d982b
Compare
rosstimothy
changed the title
rosstimothy
force-pushed
the
tross/backport-54687/v16
branch
4 times, most recently
from
5f55f27 to
f4f8a6e
Compare
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
force-pushed
the
tross/backport-54687/v16
branch
from
f4f8a6e to
9cdd8bf
Compare
hugoShaka
approved these changes
May 13, 2025
espadolini
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #54687 to branch/v16
changelog: Prevent restrictive validation of cluster auth preferences from causing non-auth instances to become healthy.