MCP access part 3: audit events and reporting #54779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
added
no-changelog
greedy52
force-pushed
the
STeve/54705_part_3_events
branch
from
0bf3eae to
d7cee4b
Compare
github-actions
bot
added
audit-log
zmb3
reviewed
May 13, 2025
| @@ -4803,6 +4803,10 @@ message OneOf { | |||
| events.AutoUpdateAgentRolloutTrigger AutoUpdateAgentRolloutTrigger = 213; | |||
| events.AutoUpdateAgentRolloutForceDone AutoUpdateAgentRolloutForceDone = 214; | |||
| events.AutoUpdateAgentRolloutRollback AutoUpdateAgentRolloutRollback = 215; | |||
| events.MCPSessionStart MCPSessionStart = 216; | |||
| events.MCPSessionEnd MCPSessionEnd = 217; | |||
| events.MCPSessionRequest MCPSessionRequest = 218; | |||
There was a problem hiding this comment.
Does this work like app access where the requests get chunked up and stored in session recordings, or are we emitting every request directly to the audit log?
There was a problem hiding this comment.
they go straight to audit events similar to database queries. LLMs "execute" these requests based on user's behaves (like the inputs on the prompt) so don't expect a huge number of request to spam audit log. Any concern? we could introduce audit event vs recording mode for these but we never get to do that for database access.
zmb3
reviewed
May 13, 2025
kimlisa
approved these changes
May 28, 2025
zmb3
approved these changes
May 28, 2025
…/54705_part_3_events
greedy52
force-pushed
the
STeve/54705_part_3_events
branch
from
9acc0e1 to
7a02f9e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
greedy52
added a commit
that referenced
this pull request
Jun 26, 2025
* MCP access part 3: audit events and reporting * add new icon, storybook, format
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related